feat: apply some middlewares before configureServer hook#20222
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Jun 17, 2025
Merged
Conversation
Member
Author
|
/ecosystem-ci run |
commit: |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, ladle, laravel, marko, qwik, storybook, sveltekit, rakkas, vite-plugin-react, unocss, vite-environment-examples, vuepress, vite-plugin-pwa, vite-plugin-vue, nuxt, vite-setup-catalogue, quasar, vite-plugin-svelte, vitest, vitepress |
patak-dev
approved these changes
Jun 16, 2025
Member
patak-dev
left a comment
There was a problem hiding this comment.
Sounds good to me. I don't think there will be a better chance to apply this chance later on.
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves four middlewares to be applied before
configureServerhook. The four middlewares are:timeMiddlewareconfigureServerhook is included in the logrejectInvalidRequestMiddlewareconfigureSereverhook does not have to care whetherreq.urlincludes#or notcorsMiddlewareres.removeHeader('Access-Control-Allow-Origin')hostValidationMiddlewareconfigureSereverhook does not have to care about DNS rebinding attacksThese checks are currently not the responsibility of Vite, but I think it's better to include them.