Addition: computed role mappings for html elements#465
Merged
scottaohara merged 10 commits intogh-pagesfrom Jun 6, 2023
Merged
Addition: computed role mappings for html elements#465scottaohara merged 10 commits intogh-pagesfrom
scottaohara merged 10 commits intogh-pagesfrom
Conversation
resolves #464 The initial PR adds the computed role cell to all HTML elements. Where possible, the cells have been filled in with 'use aria mappings', 'not mapped' or 'see comments' or '???'. The ??? instances are those where there are host-language roles that need to be determined for elements which are important to accessibility but have no explicit ARIA role to neatly map to.
includes computed role th for the tables revises the class name from 'computed-role' to 'role-computed' which is backwards, but matches how it was added in core aam.
cookiecrook
approved these changes
Apr 4, 2023
Collaborator
cookiecrook
left a comment
There was a problem hiding this comment.
With or without the <dl> comment, this is good to go to get the non-controversial column in. Would be nice to file a new issue or two to track what happens to audio/video and the various extra input types once we have consensus on w3c/aria#529
Collaborator
Is merging into |
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
This was referenced May 9, 2023
Member
Author
|
@spectranaut @cookiecrook finished removing the placeholder "???" i had for some computed roles, and added in a few notes relating to other issues where the computed roles may change (dl/dt/dd and the aria association list issue, header/footer) |
takes what was in the comment and adds it to computed role cell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #464
The initial PR adds the computed role cell to all HTML elements. Where possible, the cells have been filled in with 'use aria mappings', 'not mapped' or 'see comments' or '???'. The ??? instances are those where there are host-language roles that need to be determined for elements which are important to accessibility but have no explicit ARIA role to neatly map to.
Preview | Diff