disallow aria-hidden on body element#447
Merged
scottaohara merged 5 commits intogh-pagesfrom Mar 6, 2023
Merged
Conversation
related to w3c/aria#1254 closes #221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
as `aria-hidden=false` doesn't seem to cause any problems, even per the note in ARIA to use with caution: >At the time of this writing, aria-hidden="false" is known to work inconsistently in browsers. As future implementations improve, use caution and test thoroughly before relying on this approach. let's limit this rule to just `aria-hidden=true`
This was referenced Mar 3, 2023
patrickhlauke
approved these changes
Mar 6, 2023
Member
patrickhlauke
left a comment
There was a problem hiding this comment.
This LGTM, thanks @scottaohara
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to w3c/aria#1254
closes #221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
labels: needs implementation commitment, needs changelog entry
Preview | Diff