Update: acknowledge the image role#533
Merged
scottaohara merged 3 commits intogh-pagesfrom Dec 13, 2024
Merged
Conversation
role=`image` is the preferred default role, over the previous and still valid `img` role. update the spec to call out the existence / allowance of the `image` role.
scottaohara
commented
Dec 13, 2024
Member
Author
|
though only 1 checker supports this for now, being that it's a role that all browsers support and is the preferred role for how browsers expose the img element - i have high confidence this is fine / checkers will update to account for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
role=
imageis the preferred default role, over the previous and still validimgrole.update the spec to call out the existence / allowance of the
imagerole.labels: needs implementation commitment, needs changelog entry
Closes #481
test case:
imagerolePreview | Diff