Make sure document is associated with the registry when try to upgrade#57727
Open
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Open
Make sure document is associated with the registry when try to upgrade#57727chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
e26444e to
66de192
Compare
There's an edge case where the document is not associated with the scoped registry so the custom element is not upgraded when the CE is defined. Bug: 40826514 Change-Id: I66ea1ae265d249fef0761d3962dc3dc1e26d7012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7563664 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Jayson Chen <jaysonchen@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1584866}
66de192 to
89a990e
Compare
wpt-pr-bot
approved these changes
Feb 13, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an edge case where the document is not associated with the
scoped registry so the custom element is not upgraded when the CE is
defined.
Bug: 40826514
Change-Id: I66ea1ae265d249fef0761d3962dc3dc1e26d7012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7563664
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1584866}