chore: Set AES128GCM as default encoding#222
Merged
martijndwars merged 1 commit intoweb-push-libs:masterfrom Jul 6, 2025
Merged
chore: Set AES128GCM as default encoding#222martijndwars merged 1 commit intoweb-push-libs:masterfrom
martijndwars merged 1 commit intoweb-push-libs:masterfrom
Conversation
Member
|
Thanks! |
|
@martijndwars Could you push 5.2.0 to maven repository as well? |
Member
|
Maven Central changed their integration and we need to update some plugins -- hope to get to it later this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the default encryption encoding used in the
PushServiceclass fromAESGCMtoAES128GCM.Rationale
While
AESGCMis a newer encoding method, some modern browsers (e.g., Chrome, Edge) currently do not properly trigger service workers when receiving push notifications encoded withaesgcm.By contrast,
aes128gcmis widely supported and works reliably across all major browsers. This change ensures more consistent and reliable push notification delivery.Changes
send(Notification)method inPushServiceto useEncoding.AES128GCMby default.Reference
##Notes