Removed guava compile dependency#68
Conversation
…ommons base64 encoding which is only 327kb.
|
Thanks! I think keeping Guava as a testCompile dependency is okay. I'll take a better look at the changes asap. Our of curiosity: do you have a use-case in which the size of the dependency (Guava vs. commons codec) actually matters? Would it make sense to implement base64 encoding ourselves, and not rely on a dependency at all (e.g. to avoid licensing issues)? |
not really. i just stumbled across this because my deployment artifact grew quite a bit. among others i found this guava dependency (which i thought wasn't even used)
yes, prefered! i just wouldn`t spend much time on this. not better taking an existing one from some other os project? most newer are apache 2 licensed. does this work with MIT? |
…apache-httpcomponents
|
just realized that commons-codec was already included as dependency - via apache-httpcomponents. I removed the explicit declaration from build.gradle. This means no additional jars with this pr... |
|
Thanks! Merged! |
@martijndwars I kept guava as testCompile dependency for now. just to make sure that there are non breaking changes with this pr (see Base64EncoderTest). but this could be removed as well. what do you think?