Fix select base appearance shadow tree issues#12158
Conversation
- Corrects links to the css spec which have changed since I added them. - Adds the "select" argument to ::picker - Changes code to span for referencing select button slot Fixes whatwg#12106
source
Outdated
There was a problem hiding this comment.
| <li><p>A <dfn>select button slot</dfn>, which is a <code>slot</code> element. It is appended to | |
| the <code>select</code>'s <span>shadow root</span> as the first child. It is | |
| <span>expected</span> to take the first child element of the <code>select</code> if the first | |
| child element is a <code>button</code>.</p></li> |
There was a problem hiding this comment.
I think this is correct. Though I'm not sure about the "take" terminology, but I guess we use that elsewhere? We take care of the fallback in the next step.
There was a problem hiding this comment.
Thanks, I added this change.
Yeah the "take" terminology is something that I copied from the details element:
The first child element is a slot that is expected to take the details element's first summary element child, if any
There was a problem hiding this comment.
I'm not 100% sure that phrasing is correct. It takes the first button element child right? Rather than the first element child if it's a button?
Or does it really only work if the button is the very first element?
There was a problem hiding this comment.
Yes, it really only works if the button is the very first element: https://chromium-review.googlesource.com/c/chromium/src/+/6012938
annevk
left a comment
There was a problem hiding this comment.
@nt1m @lukewarlow want to review as well?
|
Lgtm |
This change is editorial.
Fixes #12106
/infrastructure.html ( diff )
/rendering.html ( diff )