Skip to content

Ensure string is passed through in process a URLPatternInit#273

Merged
annevk merged 2 commits intowhatwg:mainfrom
shannonbooth:ensure-protocol-exists
Mar 26, 2025
Merged

Ensure string is passed through in process a URLPatternInit#273
annevk merged 2 commits intowhatwg:mainfrom
shannonbooth:ensure-protocol-exists

Conversation

@shannonbooth
Copy link
Member

@shannonbooth shannonbooth commented Mar 26, 2025

There are cases in which the protocol is not present in the result map, where we instead need to pass through the empty string.

Fixes: #257


Preview | Diff

There are cases in which the protocol is not present in the result
map, where we instead need to pass through the empty string.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo nit this seems fine.

@annevk annevk merged commit 696b402 into whatwg:main Mar 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Missing not existing handling for 'protocol' in "process a URLPatternInit"

2 participants