fix: fix performance issue with adjacent product in 6.9 #2202
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
approved these changes
Dec 9, 2025
Contributor
kmanijak
left a comment
There was a problem hiding this comment.
I was able to reproduce the issue and confirm this PR fixes the problem with WP 6.9. Double-checked on WP 6.8 as well (btw great job with the if statement so it's backward compatible).
Also, I think it's fine to do a string replacement rather than regex based replacement given this part is static in the original code (except for comparison operator but you took it into account).
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce#62233
AND p.IDfallback inget_adjacent_post(). When two products share the same publish date and the adjacent one is hidden, the query could repeat/hang because the ID wasn’t swapped in that clause. This PR fix this issue by altering the clause with not only date but also the current product ID.Screenshots
How to test the changes in this Pull Request:
Polo) and note its next product (e.g.,T-Shirt with Logo).T-Shirt with Logo): set its publish date/time to exactly match the first product and set visibility to Hidden.Changelog