Skip to content

Add --exclude=<hooks> argument to wp cron event run #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielbachhuber merged 7 commits into from
May 25, 2023
Merged

Add --exclude=<hooks> argument to wp cron event run #97

danielbachhuber merged 7 commits into from
May 25, 2023

Conversation

@rutviksavsani
Copy link
Contributor

@rutviksavsani rutviksavsani commented May 24, 2023 •
edited
Loading

Fix #55

  • This pull request adds the --exclude flag to the wp cron event run command.
  • The flag accepts a list of comma separated hooks that will be excluded from the list of events.

Working:

  • Without the exclude flag

image

  • With the exclude flag

image

@rutviksavsani rutviksavsani requested a review from a team as a code owner May 24, 2023 13:48
@danielbachhuber danielbachhuber changed the title Add exclude flag in wp cron event run command. Add --exclude=<hooks> argument to wp cron event run May 25, 2023
danielbachhuber
danielbachhuber reviewed May 25, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Just a couple nits to address.

@wojsmol
Copy link
Contributor

wojsmol commented May 25, 2023

@rutviksavsani Please update Issue: #55 to Fix #55 so Github will auto close related issue on PR merge.

rutviksavsani and others added 2 commits May 25, 2023 18:48
@rutviksavsani @danielbachhuber
Update flag description.
d8df3d0 
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
@rutviksavsani
Increase readability.
c1c07d1
@rutviksavsani
Copy link
Contributor Author

rutviksavsani commented May 25, 2023

Hi @danielbachhuber
I have addressed the feedback as suggested.
Thanks!

@danielbachhuber
Copy link
Member

danielbachhuber commented May 25, 2023

I have addressed the feedback as suggested.

@rutviksavsani Awesome, thanks! I added one more test with f879760

Nice work on this 😊

@danielbachhuber danielbachhuber added this to the 2.2.2 milestone May 25, 2023
@danielbachhuber danielbachhuber merged commit c63ac49 into wp-cli:main May 25, 2023
@Mike-Hermans Mike-Hermans mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

command:cron command:cron-event command:cron-event-run

Projects

None yet

Milestone

2.2.2

Development

Successfully merging this pull request may close these issues.

Feature Request: cron event --exclude

3 participants

@rutviksavsani @wojsmol @danielbachhuber