Skip to content

Fix minor PHPCS violation #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 1 commit into from
Nov 5, 2019
Merged

Fix minor PHPCS violation #273

schlessera merged 1 commit into from
Nov 5, 2019

Conversation

@thrijith
Copy link
Member

@thrijith thrijith commented Nov 4, 2019

Fix violation causing build failure here https://travis-ci.org/wp-cli/entity-command/jobs/607188276#L587-L595

Got this when I merged #266, not sure why it was not reported while WP_CLI_CS was implemented.

@thrijith thrijith requested a review from a team as a code owner November 4, 2019 15:43
@thrijith
Copy link
Member Author

thrijith commented Nov 5, 2019

@schlessera is the job failure due to the declaration of feedback in https://github.com/wp-cli/wp-cli/blob/904f35f541697ac9c939c42b6742b99c32015d5b/php/WP_CLI/Compat/Min_PHP_5_6/FeedbackMethodTrait.php#L12 which accepts 2 params?

Also $args_array and $arg in the function doesn't seem to be used

public function feedback( $string, ...$args ) { // phpcs:ignore PHPCompatibility.LanguageConstructs.NewLanguageConstructs.t_ellipsisFound
	$args_array = [];
	foreach ( $args as $arg ) {
		$args_array[] = $args;
	}

	$this->process_feedback( $string, $args );
}

@schlessera
Copy link
Member

schlessera commented Nov 5, 2019

@thrijith This was fixed in wp-cli/wp-cli#5283

We could move to dev-master on wp-cli/wp-cli to get the tests to pass, but I'm just merging this one as-is for now.

@schlessera schlessera added the bug label Nov 5, 2019
@schlessera schlessera added this to the 2.0.7 milestone Nov 5, 2019
@schlessera schlessera merged commit 86baa1a into master Nov 5, 2019
@schlessera schlessera deleted the fix/sniff-vioaltion branch November 5, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

2.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@thrijith @schlessera