Skip to content

Warn when supplying multiple themes with theme install --activate #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 3 commits into from
Apr 26, 2024
Merged

Warn when supplying multiple themes with theme install --activate #408

swissspidy merged 3 commits into from
Apr 26, 2024

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 21, 2024

Fixes #406

@ernilambar ernilambar requested a review from a team as a code owner February 21, 2024 09:26
swissspidy
swissspidy reviewed Feb 21, 2024
View reviewed changes
@swissspidy swissspidy added the command:theme-install Related to 'theme install' command label Feb 21, 2024
@swissspidy swissspidy added this to the 2.1.20 milestone Feb 21, 2024
@ernilambar ernilambar requested a review from swissspidy March 20, 2024 11:34
swissspidy
swissspidy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wp-cli/wp-cli#5935

@swissspidy swissspidy merged commit afdbff3 into wp-cli:main Apr 26, 2024
@ernilambar ernilambar deleted the 406-fix-activate-multiple-themes branch April 26, 2024 09:35
@danielbachhuber danielbachhuber mentioned this pull request Apr 26, 2024
Merged
@danielbachhuber
Copy link
Member

danielbachhuber commented Apr 26, 2024

Slight tweak for a follow-up: #419

@danielbachhuber danielbachhuber changed the title Warn multiple themes installation with activate Warn when supplying multiple themes with theme install --activate Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

command:theme-install Related to 'theme install' command

Projects

None yet

Milestone

2.1.20

Development

Successfully merging this pull request may close these issues.

Block passing --activate in theme install with multiple themes

3 participants

@ernilambar @danielbachhuber @swissspidy