Skip to content

Fix test involving WordPress trunk #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ernilambar merged 2 commits into from
Jan 9, 2026
Merged

Fix test involving WordPress trunk #360

ernilambar merged 2 commits into from
Jan 9, 2026
+4 −4

Conversation

@swissspidy
Copy link
Member

@swissspidy swissspidy commented Jan 9, 2026

WordPress trunk requires PHP 7.4 now

@swissspidy swissspidy requested a review from a team as a code owner January 9, 2026 13:54
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 9, 2026

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue within the test suite by updating the required PHP version for tests that involve installing WordPress from its trunk development branch. The change ensures that these tests correctly reflect the latest WordPress development requirements, which now mandate PHP 7.4, thereby maintaining the accuracy and reliability of the testing environment.

Highlights

  • PHP Version Requirement Update: The @require-php-7.2 tag in the install-wp-tests.feature file has been updated to @require-php-7.4 for the "Install WordPress from trunk" scenario. This change aligns the test suite with WordPress trunk's new minimum PHP version requirement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 9, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the required PHP version for the 'Install WordPress from trunk' test scenario from 7.2 to 7.4. This change is necessary as WordPress trunk now requires PHP 7.4. The change is correct and aligns with the upstream dependency update. The change looks good to me.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ernilambar ernilambar merged commit 91c93ff into main Jan 9, 2026
45 checks passed
@ernilambar ernilambar deleted the fix/trunk-tests branch January 9, 2026 14:41
@swissspidy swissspidy added this to the 2.5.2 milestone Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernilambar ernilambar ernilambar approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope:testing

Projects

None yet

Milestone

2.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@swissspidy @ernilambar