Avoid fatal errors when pulling in the bundle with Requests v2 via Composer #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The changes in wp-cli/wp-cli#5796 do actually solve the issue now. The tests up here are still broken, as it is not easy to get the version in the pull request be pulled in via Composer (as it will then break after merge. So I'm merging this now with the failure, expecting the tests to pass once this is merged into |
Member
Author
|
From my initial testing now, it looks like this also allows you to use WP-CLI to run core updates across this v1/v2 boundary in both directions without any issues. |
This was referenced Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to trigger the issue described in https://github.com/wp-cli/wp-cli#5795