Updated on a couple of sites and it kills the sites completely. Had to manually roll back to older version. Happened on sites with both PHP 7.4.33 and PHP 8.3.25.
@dreamingat30fps – On it, do you happen to have the error message itself, would be really helpful as we tested on PHP 7.4 and didn’t have any crash errors (or any issues really), so thinking its something else maybe that we didn’t account for in testing somewhere.
Actually it may just be with 7.4. I updated on a 7.4 site and it crashed, rolled back and updated to 8.3 then updated it again and was fine. Dropped down to 7.4 and got this:
An error of type E_PARSE was caused in line 158 of the file /public_html/wp-content/plugins/popup-maker/includes/namespaced/utils.php. Error message: syntax error, unexpected '|', expecting variable (T_VARIABLE)
Incoming patch in the next 10-20 minutes (v1.21.1).
I’ve stripped out all usage of | in types, and am in the process of stripping out all hard coded types in general as they are simply more likely to cause problems in the WP space than help prevent them like other code-bases might.
Thank you for the rapid report and isolation.
This reply was modified 4 months ago by Daniel Iser.
@dreamingat30fps – Took a bit longer than I said, but we wanted to dissect this properly, any blanket solutions would have likely led to further issues.
We patched only as much as needed to get it working on 7.4 again.
Apologies, we tested on 7.4 a lot, but then did a bunch of type work which we assumed was all PHP 7.4 safe. Seems it all was except trying to declare a type of string|array using the | seems to be completely unavailable until 8.0. Small oversight but huge potential impact, and likely minimized by your quick ticket. 🙏
@danieliser Thank you for responding and fixing the issue so quickly. I came here to report the same error as @dreamingat30fps, so it’s great to see a fix is already available.
I’ve refreshed the plugin listing on wpackagist as well, so CI/CD systems like ours will pick up the hotfix version now.
@dmpinder – Awesome, would love a few confirmations beyond our own testing, so drop a comment as soon as you confirm no further issues if you don’t mind. I’ll be up for at least another 3 hours to make fixes if needed.
@dmpinder – HUGE!!! That is great to know. This release was a massive step for us revamping this plugin. All new build processes, more automated testing, complete restructuring of our premium features from 14 disparate features to a new Pro plugin, along with only a few niche Pro+ addons focused on LMS/Ecommerce, addition of trackable CTAs, new pro analytics, revenue tracking, advanced reporting etc.
Honestly I’ve been putting off pushing the button for nearly a week, finally wife said stop tinkering and put it out. Went well for over 2+ hours before this report, thank goodness I had already planned my day around watching for issues.
So your confirmation is great news for sure!
Sample of what I’m about to release in the next few hours hopefully. This is our own cart abandonment popup for the past few weeks running the new stuff on our own site.
