Fix ActiveAdmin::Inputs::Filters::DateRangeInput cover last day#4504
Merged
timoschilling merged 1 commit intoactiveadmin:masterfrom Jun 30, 2016
Merged
Conversation
Member
|
Thanks to @groony and you |
This was referenced Jun 30, 2016
Contributor
|
@timoschilling @dlackty I believe this breaks filtering for It tries to use date time ranges for date fields resulting in timezone conversion. My temporary workaround was to monkeypatch these two methods: ActiveAdmin::Inputs::Filters::DateRangeInput.class_eval do
def gt_input_name
case column.type
when :date
"#{method}_gteq"
else
"#{method}_gteq_date"
end
end
def lt_input_name
case column.type
when :date
"#{method}_lteq"
else
"#{method}_lteq_date"
end
end
endShould I open a separate issue? |
Member
|
@bartoszkopinski yes please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #4341 and should close #3529.
Thanks @groony for the work!