Skip to content

[ty] Add support for validating members from dynamic classes#24556

Draft
charliermarsh wants to merge 1 commit intomainfrom
charlie/dynamic-members
Draft

[ty] Add support for validating members from dynamic classes#24556
charliermarsh wants to merge 1 commit intomainfrom
charlie/dynamic-members

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Apr 11, 2026

No description provided.

@astral-sh-bot astral-sh-bot bot added the ty Multi-file analysis & type inference label Apr 11, 2026
@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Apr 11, 2026 •
edited
Loading

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.21%. The number of fully passing files held steady at 79/133.

@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Apr 11, 2026 •
edited
Loading

Memory usage report

Summary

Project Old New Diff Outcome
prefect 709.00MB 709.03MB +0.00% (33.74kB) ⏫
sphinx 262.60MB 262.62MB +0.01% (13.92kB) ⏫
trio 117.49MB 117.49MB +0.00% (1.48kB) ⏫
flake8 47.89MB 47.89MB - ✅

Significant changes

Click to expand detailed breakdown

prefect

Name Old New Diff Outcome
Type<'db>::class_member_with_policy_ 17.40MB 17.41MB +0.03% (4.85kB) ⏫
Type<'db>::member_lookup_with_policy_ 17.05MB 17.05MB +0.02% (3.90kB) ⏫
Type<'db>::class_member_with_policy_::interned_arguments 9.68MB 9.68MB +0.04% (3.86kB) ⏫
Type<'db>::member_lookup_with_policy_::interned_arguments 5.89MB 5.89MB +0.05% (2.74kB) ⏫
Type<'db>::try_call_dunder_get_::interned_arguments 2.89MB 2.90MB +0.09% (2.74kB) ⏫
enum_metadata 2.67MB 2.67MB +0.09% (2.34kB) ⏫
Type<'db>::try_call_dunder_get_ 10.48MB 10.48MB +0.02% (2.30kB) ⏫
DynamicClassLiteral 4.72kB 6.64kB +40.73% (1.92kB) ⏫
infer_definition_types 89.78MB 89.78MB +0.00% (1.75kB) ⏫
UnionType<'db>::from_two_elements_::interned_arguments 2.09MB 2.09MB +0.06% (1.29kB) ⏫
UnionType<'db>::from_two_elements_ 4.51MB 4.51MB +0.03% (1.24kB) ⏫
is_redundant_with_impl::interned_arguments 4.35MB 4.35MB +0.02% (1.03kB) ⏫
CallableType 2.12MB 2.12MB +0.04% (936.00B) ⏫
is_redundant_with_impl 4.26MB 4.26MB +0.02% (864.00B) ⏫
UnionType 2.99MB 2.99MB +0.02% (672.00B) ⏫
... 12 more

sphinx

Name Old New Diff Outcome
Type<'db>::class_member_with_policy_ 7.63MB 7.63MB +0.02% (1.66kB) ⏫
Type<'db>::apply_specialization_ 1.65MB 1.65MB +0.07% (1.20kB) ⏫
Type<'db>::apply_specialization_::interned_arguments 1.46MB 1.46MB +0.08% (1.17kB) ⏫
Type<'db>::try_call_dunder_get_ 4.88MB 4.88MB +0.02% (1.14kB) ⏫
FunctionType 3.11MB 3.11MB +0.03% (1016.00B) ⏫
Type<'db>::class_member_with_policy_::interned_arguments 4.03MB 4.03MB +0.02% (936.00B) ⏫
FunctionType<'db>::signature_ 2.27MB 2.27MB +0.03% (704.00B) ⏫
Type<'db>::member_lookup_with_policy_ 6.86MB 6.86MB +0.01% (644.00B) ⏫
Type<'db>::try_call_dunder_get_::interned_arguments 1.16MB 1.16MB +0.05% (624.00B) ⏫
FunctionType<'db>::last_definition_signature_ 221.68kB 222.20kB +0.23% (532.00B) ⏫
InferableTypeVarsInner 85.06kB 85.48kB +0.49% (424.00B) ⏫
UnionType<'db>::from_two_elements_ 1.21MB 1.21MB +0.03% (396.00B) ⏫
GenericContext 135.76kB 136.14kB +0.28% (392.00B) ⏫
enum_metadata 706.70kB 707.05kB +0.05% (368.00B) ⏫
is_redundant_with_impl::interned_arguments 1.73MB 1.73MB +0.02% (352.00B) ⏫
... 13 more

trio

Name Old New Diff Outcome
infer_expression_types_impl 7.03MB 7.03MB +0.01% (468.00B) ⏫
infer_scope_types_impl 4.75MB 4.75MB -0.01% (432.00B) ⏫
Type<'db>::member_lookup_with_policy_::interned_arguments 925.44kB 925.13kB -0.03% (312.00B) ⏫
Type<'db>::class_member_with_policy_::interned_arguments 1.13MB 1.13MB +0.02% (208.00B) ⏫
code_generator_of_dynamic_class 68.00B 272.00B +300.00% (204.00B) ⏫
DynamicClassLiteral 864.00B 1.03kB +22.22% (192.00B) ⏫
enum_metadata 232.28kB 232.46kB +0.08% (184.00B) ⏫
is_redundant_with_impl::interned_arguments 506.86kB 507.03kB +0.03% (176.00B) ⏫
IntersectionType 201.64kB 201.80kB +0.08% (168.00B) ⏫
Type<'db>::class_member_with_policy_ 2.05MB 2.05MB +0.01% (152.00B) ⏫
is_redundant_with_impl 438.67kB 438.81kB +0.03% (144.00B) ⏫
Type<'db>::member_lookup_with_policy_ 1.95MB 1.95MB -0.01% (144.00B) ⏫
UnionType<'db>::from_two_elements_ 272.75kB 272.88kB +0.05% (128.00B) ⏫
UnionType 285.50kB 285.61kB +0.04% (112.00B) ⏫
Type<'db>::try_call_dunder_get_::interned_arguments 348.26kB 348.36kB +0.03% (104.00B) ⏫
... 2 more

@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Apr 11, 2026 •
edited
Loading

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@charliermarsh charliermarsh force-pushed the charlie/dynamic-members branch 2 times, most recently from a642142 to 1d34946 Compare April 11, 2026 18:01
@charliermarsh charliermarsh force-pushed the charlie/namedtuple-overrides-i branch 3 times, most recently from eb24653 to 6a04fdc Compare April 14, 2026 15:21
Base automatically changed from charlie/namedtuple-overrides-i to main April 14, 2026 15:30
@charliermarsh charliermarsh force-pushed the charlie/dynamic-members branch from 1d34946 to 1cab6f3 Compare April 14, 2026 23:33
@charliermarsh charliermarsh force-pushed the charlie/dynamic-members branch from 1cab6f3 to 56a30e8 Compare April 15, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager will be requested when the pull request is marked ready for review dcreager is a code owner

@ibraheemdev ibraheemdev Awaiting requested review from ibraheemdev ibraheemdev will be requested when the pull request is marked ready for review ibraheemdev is a code owner

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charliermarsh