Failure if best_elem is root (fix #58)#65
Merged
buriy merged 1 commit intoburiy:masterfrom May 6, 2015
avalanchy:best_elem_is_root
Merged
Failure if best_elem is root (fix #58)#65buriy merged 1 commit intoburiy:masterfrom avalanchy:best_elem_is_root
buriy merged 1 commit intoburiy:masterfrom
avalanchy:best_elem_is_root
Conversation
buriy
added a commit
that referenced
this pull request
May 6, 2015
Failure if best_elem is root (fix #58) Thanks a lot @avalanchy and @jnothman !
Author
|
@buriy: I just wanna pin on this change to my project. Can I expect release to pypi in this week? If not I will just reference this directly from github. |
Owner
|
Yes, I'll do a release 0.6 by the end of the week (most probably, tomorrow) after checking if all the changes work fine and fixing several remaining logging issues. |
Owner
|
".../python-readability/readability/readability.py:216: FutureWarning: The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead. |
buriy
added a commit
that referenced
this pull request
May 6, 2015
Author
|
It just build up with my project. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces and fixes issue #58