Skip to content

Add to_df() to convert get_online_feature response to pandas dataframe#1623

Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
tedhtchang:get-online-feature-to-df
Jun 14, 2021
Merged

Add to_df() to convert get_online_feature response to pandas dataframe#1623
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
tedhtchang:get-online-feature-to-df

Conversation

@tedhtchang
Copy link
Copy Markdown
Contributor

@tedhtchang tedhtchang commented Jun 7, 2021

Signed-off-by: ted chang htchang@us.ibm.com

What this PR does / why we need it:
Convert online response to Panda dataframe

Which issue(s) this PR fixes:
Fixes #1613

Does this PR introduce a user-facing change?:

Users can convert online feature response to Panda dataframe

@tedhtchang tedhtchang requested review from a team, achals, tsotnet and woop as code owners June 7, 2021 10:53
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jun 7, 2021

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@achals
Copy link
Copy Markdown
Member

achals commented Jun 7, 2021

/ok-to-test

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 7, 2021 •
edited
Loading

Codecov Report

Merging #1623 (77cda24) into master (b32e766) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   83.39%   83.47%   +0.08%     
==========================================
  Files          71       71              
  Lines        6113     6144      +31     
==========================================
+ Hits         5098     5129      +31     
  Misses       1015     1015
Flag Coverage Δ
integrationtests 83.39% <100.00%> (+0.08%) ⬆️
unittests 76.57% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 92.95% <ø> (ø)
sdk/python/feast/online_response.py 97.43% <100.00%> (+0.21%) ⬆️
sdk/python/tests/test_online_retrieval.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32e766...77cda24. Read the comment docs.

@woop
Copy link
Copy Markdown
Member

woop commented Jun 7, 2021

Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005

@woop woop added the kind/feature New feature or request label Jun 7, 2021
woop
woop reviewed Jun 7, 2021
View reviewed changes
Comment thread sdk/python/tests/test_online_retrieval.py Outdated
@woop
Copy link
Copy Markdown
Member

woop commented Jun 7, 2021

Thanks @tedhtchang, this is great!

@tedhtchang tedhtchang force-pushed the get-online-feature-to-df branch from 0b4fffd to 12d7eac Compare June 10, 2021 02:06
@woop
Copy link
Copy Markdown
Member

woop commented Jun 11, 2021

Thanks @tedhtchang

achals
achals requested changes Jun 14, 2021
View reviewed changes
Comment thread sdk/python/tests/test_online_retrieval.py Outdated
@tedhtchang
Add to_df() to convert get_online_feature response to pandas dataframe
3baa422 
Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang tedhtchang force-pushed the get-online-feature-to-df branch from 12d7eac to 5ada579 Compare June 14, 2021 21:09
@tedhtchang
Add dataframe column and row consistency test
77cda24 
Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang tedhtchang force-pushed the get-online-feature-to-df branch from 5ada579 to 77cda24 Compare June 14, 2021 21:11
achals
achals approved these changes Jun 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d71b452 into feast-dev:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

@woop woop woop approved these changes

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees

@achals achals

Labels

approved kind/feature New feature or request lgtm ok-to-test release-note size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add to_df() to OnlineResponse

5 participants

@tedhtchang @feast-ci-bot @achals @codecov-commenter @woop