Skip to content

fix: Disable Redis RDB persistence in test deployments#6282

Merged
ntkathole merged 1 commit intofeast-dev:masterfrom
Srihari1192:fixRedisTestImageDBPersistence
Apr 15, 2026
Merged

fix: Disable Redis RDB persistence in test deployments#6282
ntkathole merged 1 commit intofeast-dev:masterfrom
Srihari1192:fixRedisTestImageDBPersistence

Conversation

@Srihari1192
Copy link
Copy Markdown
Contributor

@Srihari1192 Srihari1192 commented Apr 15, 2026

What this PR does / why we need it:

Add command: ["redis-server", "--save", ""] to disable RDB snapshotting
in both test Redis deployments. These are ephemeral test instances — no
data needs to survive pod restarts.

Which issue(s) this PR fixes:

Redis pods on OpenShift fail with MISCONF error:

Redis is configured to save RDB snapshots, but it's currently unable
to persist to disk. Commands that may modify the data set are disabled,
because this instance is configured to report errors during writes if
RDB snapshotting fails (stop-writes-on-bgsave-error option).

This blocks all write commands during e2e and REST API integration tests,
causing materialization failures.

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

Signed-off-by: Srihari <svenkata@redhat.com>
@Srihari1192 Srihari1192 marked this pull request as ready for review April 15, 2026 10:09
@Srihari1192 Srihari1192 requested a review from a team as a code owner April 15, 2026 10:09
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@Srihari1192 Srihari1192 changed the title fix: disable Redis RDB persistence in test deployments fix: Disable Redis RDB persistence in test deployments Apr 15, 2026
@ntkathole ntkathole merged commit 44cd682 into feast-dev:master Apr 15, 2026
40 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants