Skip to content

chore: migration batch 4#16661

Merged
jskeet merged 49 commits intogoogleapis:mainfrom
jskeet:batch-4
Apr 15, 2026
Merged

chore: migration batch 4#16661
jskeet merged 49 commits intogoogleapis:mainfrom
jskeet:batch-4

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 15, 2026

Generated packages:

  • google-cloud-gke-connect-gateway
  • google-cloud-gke-multicloud
  • google-cloud-gkerecommender
  • google-cloud-gsuiteaddons
  • google-cloud-hypercomputecluster
  • google-cloud-iam
  • google-cloud-iamconnectorcredentials
  • google-cloud-iam-logging
  • google-cloud-iap
  • google-cloud-ids
  • google-cloud-kms
  • google-cloud-kms-inventory
  • google-cloud-language
  • google-cloud-licensemanager
  • google-cloud-life-sciences
  • google-cloud-locationfinder
  • google-cloud-logging
  • google-cloud-lustre
  • google-cloud-maintenance-api
  • google-cloud-managed-identities
  • google-cloud-managedkafka
  • google-cloud-managedkafka-schemaregistry
  • google-cloud-media-translation
  • google-cloud-memcache
  • google-cloud-memorystore
  • google-cloud-migrationcenter
  • google-cloud-modelarmor
  • google-cloud-monitoring
  • google-cloud-monitoring-metrics-scopes
  • google-cloud-netapp
  • google-cloud-network-management
  • google-cloud-network-security
  • google-cloud-network-services
  • google-cloud-notebooks
  • google-cloud-optimization
  • google-cloud-oracledatabase
  • google-cloud-orchestration-airflow
  • google-cloud-org-policy
  • google-cloud-os-config
  • google-cloud-parallelstore
  • google-cloud-parametermanager
  • google-cloud-phishing-protection
  • google-cloud-policysimulator
  • google-cloud-policy-troubleshooter
  • google-cloud-private-ca
  • google-cloud-private-catalog
  • google-cloud-privilegedaccessmanager
  • google-cloud-quotas
  • google-cloud-rapidmigrationassessment

jskeet added 29 commits April 15, 2026 14:23
@jskeet jskeet requested a review from parthea April 15, 2026 14:32
@jskeet jskeet requested a review from a team as a code owner April 15, 2026 14:32
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates .repo-metadata.json files across numerous Google Cloud Python client libraries, standardizing indentation, reordering keys, and updating metadata fields. Feedback was provided regarding several data quality issues: the product_documentation for locationfinder is incorrectly set to an issue tracker URL, the api_description for lustre uses a placeholder value, and the product_documentation for network-services is too generic.

"library_type": "GAPIC_AUTO",
"name": "google-cloud-locationfinder",
"name_pretty": "Cloud Location Finder API",
"product_documentation": "https://issuetracker.google.com/issues/new?component=1569265\u0026template=1988535",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The product_documentation field is incorrectly set to the issue tracker URL. It should point to the actual product documentation page for the Cloud Location Finder API.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jskeet PTAL

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an existing value. We have an issue to revisit overrides later, but I'll make a note separately.

"product_documentation": "https://cloud.google.com/managed-lustre/docs",
"release_level": "preview",
"repo": "googleapis/google-cloud-python"
"api_description": "null ",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The api_description value "null " appears to be a placeholder. Please provide a meaningful description for the Google Cloud Managed Lustre API.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jskeet PTAL

"library_type": "GAPIC_AUTO",
"name": "networkservices",
"name_pretty": "Network Services",
"product_documentation": "https://cloud.google.com",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The product_documentation link https://cloud.google.com is too generic. It should point to the specific documentation for Network Services to be useful for users.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jskeet PTAL

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these are existing values - we can revisit later.

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 15, 2026

The prerelease failure is only a single package google-cloud-datastore.

FAILED tests/unit/test_client.py::TestClient::test_constructor_no_args_emulator
FAILED tests/unit/test_client.py::TestClient::test_constructor_get_project_from_environ

We may want to remove this package from the PR while we investigate.

=================================== FAILURES ===================================
_________________ TestClient.test_constructor_no_args_emulator _________________

    @staticmethod
    def test_constructor_no_args_emulator():
        patch_environ = mock.patch.dict(
            "google.cloud.ndb.client.os.environ",
            {"DATASTORE_EMULATOR_HOST": "foo"},
        )
        with patch_environ:
            with patch_credentials("testing"):
                client = client_module.Client()
        assert client.SCOPE == ("https://www.googleapis.com/auth/datastore",)
        assert client.host == "foo"
>       assert client.project == "testing"
E       AssertionError: assert 'precise-truck-742' == 'testing'
E         
E         - testing
E         + precise-truck-742

tests/unit/test_client.py:65: AssertionError
_____________ TestClient.test_constructor_get_project_from_environ _____________

environ = {'CLOUDSDK_PYTHON': 'python3.12', 'CLOUD_SDK_VERSION': '557.0.0', 'DATASTORE_DATASET': 'gcd-project', 'DEBIAN_FRONTEND': 'noninteractive', ...}

    @staticmethod
    def test_constructor_get_project_from_environ(environ):
        environ[environment_vars.GCD_DATASET] = "gcd-project"
        with patch_credentials(None):
            client = client_module.Client()
>       assert client.project == "gcd-project"
E       AssertionError: assert 'precise-truck-742' == 'gcd-project'
E         
E         - gcd-project
E         + precise-truck-742

tests/unit/test_client.py:75: AssertionError

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 15, 2026

Removed google-cloud-ndb for now

@jskeet jskeet merged commit e22a1f1 into googleapis:main Apr 15, 2026
30 checks passed
@GinTama12
Copy link
Copy Markdown

Not bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants