chore: complete bigframes migration#16682
Open
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Open
Conversation
Contributor
jskeet
commented
Apr 16, 2026
- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the bigframes library to a stable release level, updates its metadata, and adds a detailed README.rst documentation file. Review feedback suggests consolidating split imports from the same module in loader.py for better idiomatic consistency and correcting a typo in the documentation.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/bigframes/bigframes/session/loader.py (55-60)
The imports from google.cloud.bigquery_storage_v1 have been split into two separate blocks. It is more idiomatic in Python to group imports from the same module together in a single block.
from google.cloud.bigquery_storage_v1 import (
types as bq_storage_types,
writer as bq_storage_writer,
)References
- PEP-8 recommends grouping imports from the same module together to improve readability and organization. (link)
packages/bigframes/docs/README.rst (40)
There is a typo and redundant word in this line: "environment enviroment".
for your local development environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.