Skip to content

Updating Comments.#124

Merged
gregmalcolm merged 2 commits intogregmalcolm:masterfrom
adityagupta679:patch-1
Jan 25, 2016
Merged

Updating Comments.#124
gregmalcolm merged 2 commits intogregmalcolm:masterfrom
adityagupta679:patch-1

Conversation

@adityagupta679
Copy link
Copy Markdown
Contributor

It should be True instead of true.

A user can write true by modifying the argument "False" in lines 17 and 23 in Python3 and lines 18 and 24 in Python2 files : "about_asserts.py". However that wont work , because the right keyword is "True". Hence the proposed change.

It should be True instead of true.

A user can write true by modifying the argument "False" in lines 18 and 24 . However that wont work , because the right keyword is "True". Hence the proposed change.
@gregmalcolm
Copy link
Copy Markdown
Owner

Thanks!

gregmalcolm added a commit that referenced this pull request Jan 25, 2016
@gregmalcolm gregmalcolm merged commit 7a978d0 into gregmalcolm:master Jan 25, 2016
@adityagupta679
Copy link
Copy Markdown
Contributor Author

Welcome @gregmalcolm , happy to be of help . I am a noob at opensource contributing . I would be grateful if you could guide me towards some more small bugs or issues that i might be able to fix as a beginner , or maybe give me some general advise .

@gregmalcolm
Copy link
Copy Markdown
Owner

Thanks for the interest, but Python Koans is really low maintenance these days. Occasionally people report things as Issues but they usually boil down to suggestions that arn't necessarily the way to go. Most of tye PRs these days are spelling corrections or minor tweaks like this one.

The most useful contribution honestly would be testing other peoples PRs as they come in and confirming if they work.

@adityagupta679
Copy link
Copy Markdown
Contributor Author

Ok , thanks. I will do that.

On Mon, Jan 25, 2016 at 10:15 PM, Greg Malcolm notifications@github.com
wrote:

Thanks for the interest, but Python Koans is really low maintenance these
days. Occasionally people report things as Issues but they usually boil
down to suggestions that arn't necessarily the way to go. Most of tye PRs
these days are spelling corrections or minor tweaks like this one.

The most useful contribution honestly would be testing other peoples PRs
as they come in and confirming if they work.


Reply to this email directly or view it on GitHub
#124 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants