Skip to content

ROX-10025: Implement scoped search for secrets#1235

Merged
rhybrillou merged 1 commit intomasterfrom
yann/ROX-10025-Implement_scoped_search_for_secrets
Apr 12, 2022
Merged

ROX-10025: Implement scoped search for secrets#1235
rhybrillou merged 1 commit intomasterfrom
yann/ROX-10025-Implement_scoped_search_for_secrets

Conversation

@rhybrillou
Copy link
Copy Markdown
Contributor

Checklist

  • Investigated and inspected CI test results
    - [ ] Unit test and regression tests added
    - [ ] Evaluated and added CHANGELOG entry if required
    - [ ] Determined and documented upgrade steps
    - [ ] Documented user facing changes (create PR based on stackrox/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Pulled and ran integration tests written in #942

@ghost
Copy link
Copy Markdown

ghost commented Apr 8, 2022

Tag for build #421099 is 3.69.x-364-ga3b0b2d044.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.69.x-364-ga3b0b2d044'

🕹️ A roxctl binary can be downloaded from the CircleCI artifacts.

@rhybrillou rhybrillou marked this pull request as ready for review April 8, 2022 13:01
@rhybrillou rhybrillou requested a review from a team as a code owner April 8, 2022 13:01
@rhybrillou rhybrillou force-pushed the yann/ROX-10025-Implement_scoped_search_for_secrets branch from 8431eca to b40c55f Compare April 11, 2022 06:48
@janisz
Copy link
Copy Markdown
Contributor

janisz commented Apr 11, 2022

What's the plan for merging this? Do we need to merge #942 first?

@rhybrillou rhybrillou requested a review from janisz April 11, 2022 12:00
@rhybrillou rhybrillou force-pushed the yann/ROX-10025-Implement_scoped_search_for_secrets branch from b40c55f to a3b0b2d Compare April 12, 2022 07:18
@rhybrillou rhybrillou merged commit 41d157a into master Apr 12, 2022
@rhybrillou rhybrillou deleted the yann/ROX-10025-Implement_scoped_search_for_secrets branch April 12, 2022 09:59
janisz added a commit that referenced this pull request Apr 13, 2026
Convert PR numbers from plain text to clickable GitHub links using
rich_text cells with multiple link elements.

Changes:
- PR column now uses rich_text cell with link elements
- Each PR is a clickable link: #1234#1234
- Multiple PRs separated by commas: #1234, #1235
- Empty state remains plain text: "—"

Example table cell structure:
{
  "type": "rich_text",
  "elements": [{
    "type": "rich_text_section",
    "elements": [
      {"type": "link", "url": "https://...", "text": "#1234"},
      {"type": "text", "text": ", "},
      {"type": "link", "url": "https://...", "text": "#1235"}
    ]
  }]
}

Users can now click PR numbers directly in Slack tables to view
the pull requests on GitHub.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
janisz added a commit that referenced this pull request Apr 13, 2026
Replace separate "PRs Missing Jira" and "Issues with Missing Metadata"
sections with one unified "Release Contents" table showing everything.

Changes:
- New _create_all_pr_rows() function collects all PRs and issues
- All PRs shown in table (with or without Jira)
- All issues shown (complete and incomplete metadata)
- PRs without Jira show "No Jira" in Issue column
- Problems sorted first (incomplete), then by urgency
- Complete items shown after problems

Table structure:
- Urgency | Issue | fixVersion | affectedVersion | Priority | Severity | Deadline | PRs
- Shows ❌ for missing metadata, ✅ for present
- "No Jira" for PRs without Jira reference
- "—" for N/A fields

Benefits:
- Single comprehensive view of entire release
- Problems highlighted at top (sorted by completeness, then urgency)
- No separate sections to cross-reference
- Easy to see both what's good and what needs attention

Example rows:
- ❌ issue: ROX-123 | ❌ | ✅ | :jira-critical: | Important | Due: 2d | #1234
- ✅ issue: ROX-456 | ✅ | ✅ | :jira-major: | — | — | #1235
- No Jira PR: — | No Jira | — | — | — | — | — | #1236

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants