ROX-10025: Implement scoped search for secrets#1235
Merged
rhybrillou merged 1 commit intomasterfrom Apr 12, 2022
Merged
Conversation
|
Tag for build #421099 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.69.x-364-ga3b0b2d044'🕹️ A |
2 tasks
8431eca to
b40c55f
Compare
Contributor
|
What's the plan for merging this? Do we need to merge #942 first? |
janisz
approved these changes
Apr 11, 2022
b40c55f to
a3b0b2d
Compare
janisz
added a commit
that referenced
this pull request
Apr 13, 2026
Convert PR numbers from plain text to clickable GitHub links using rich_text cells with multiple link elements. Changes: - PR column now uses rich_text cell with link elements - Each PR is a clickable link: #1234 → #1234 - Multiple PRs separated by commas: #1234, #1235 - Empty state remains plain text: "—" Example table cell structure: { "type": "rich_text", "elements": [{ "type": "rich_text_section", "elements": [ {"type": "link", "url": "https://...", "text": "#1234"}, {"type": "text", "text": ", "}, {"type": "link", "url": "https://...", "text": "#1235"} ] }] } Users can now click PR numbers directly in Slack tables to view the pull requests on GitHub. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
janisz
added a commit
that referenced
this pull request
Apr 13, 2026
Replace separate "PRs Missing Jira" and "Issues with Missing Metadata" sections with one unified "Release Contents" table showing everything. Changes: - New _create_all_pr_rows() function collects all PRs and issues - All PRs shown in table (with or without Jira) - All issues shown (complete and incomplete metadata) - PRs without Jira show "No Jira" in Issue column - Problems sorted first (incomplete), then by urgency - Complete items shown after problems Table structure: - Urgency | Issue | fixVersion | affectedVersion | Priority | Severity | Deadline | PRs - Shows ❌ for missing metadata, ✅ for present - "No Jira" for PRs without Jira reference - "—" for N/A fields Benefits: - Single comprehensive view of entire release - Problems highlighted at top (sorted by completeness, then urgency) - No separate sections to cross-reference - Easy to see both what's good and what needs attention Example rows: - ❌ issue: ROX-123 | ❌ | ✅ | :jira-critical: | Important | Due: 2d | #1234 - ✅ issue: ROX-456 | ✅ | ✅ | :jira-major: | — | — | #1235 - No Jira PR: — | No Jira | — | — | — | — | — | #1236 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
- [ ] Unit test and regression tests added- [ ] Evaluated and added CHANGELOG entry if required- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on stackrox/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
Pulled and ran integration tests written in #942