Skip to content

ROX-34154: dump PVs and PVCs on failures too#20045

Merged
porridge merged 1 commit intomasterfrom
porridge/dump-pvs
Apr 16, 2026
Merged

ROX-34154: dump PVs and PVCs on failures too#20045
porridge merged 1 commit intomasterfrom
porridge/dump-pvs

Conversation

@porridge
Copy link
Copy Markdown
Contributor

@porridge porridge commented Apr 16, 2026 •
edited
Loading

Description

The failure described in the ticket looks like a PV provisioning bug.
We will need some additional information to be sure.
The commands added by this change should be sufficient.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

CI is enough.

@porridge porridge requested a review from a team as a code owner April 16, 2026 10:36
@porridge porridge added auto-merge Auto-merge minor and patch version bumps auto-retest PRs with this label will be automatically retested if prow checks fails labels Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.63%. Comparing base (9ef4d62) to head (4ba1ab4).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20045      +/-   ##
==========================================
+ Coverage   49.56%   49.63%   +0.07%     
==========================================
  Files        2764     2765       +1     
  Lines      208442   208770     +328     
==========================================
+ Hits       103323   103633     +310     
- Misses      97464    97479      +15     
- Partials     7655     7658       +3
Flag Coverage Δ
go-unit-tests 49.63% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026 •
edited
Loading

🚀 Build Images Ready

Images are ready for commit 665cfeb. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-668-g665cfeb7f0

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

@porridge: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 4ba1ab4 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-21-qa-e2e-tests 4ba1ab4 link false /test ocp-4-21-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Apr 16, 2026

/retest

@porridge
Copy link
Copy Markdown
Contributor Author

porridge commented Apr 16, 2026

The failures are an unrelated AdmissionControllerTest flakes. Mergin.

@porridge porridge merged commit 665cfeb into master Apr 16, 2026
107 of 109 checks passed
@porridge porridge deleted the porridge/dump-pvs branch April 16, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladbologa vladbologa vladbologa approved these changes

@mclasmeier mclasmeier mclasmeier approved these changes

Assignees

No one assigned

Labels

area/operator auto-merge Auto-merge minor and patch version bumps auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@porridge @rhacs-bot @vladbologa @mclasmeier