Fix bubble backgroundColor deranged when swipe#461
Closed
zhongwuzw wants to merge 1 commit intoMessageKit:developmentfrom
Closed
Fix bubble backgroundColor deranged when swipe#461zhongwuzw wants to merge 1 commit intoMessageKit:developmentfrom
zhongwuzw wants to merge 1 commit intoMessageKit:developmentfrom
Conversation
Closed
SD10
reviewed
Mar 23, 2018
| open override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
| view.layoutIfNeeded() | ||
| messagesCollectionView.collectionViewLayout.invalidateLayout() |
Member
There was a problem hiding this comment.
The reason I haven't merged this is I'm a little concerned that the fix involves invalidating the layout on viewWillAppear. I have to check this one
Member
|
@zhongwuzw Is this still a bug? |
Member
|
@nathantannar4 It likely is, but we can't solve it this way because invalidating the layout in this place is too heavy-handed |
Member
|
Perhaps just reload the cells at the visible index paths? Sent with GitHawk |
Member
Author
|
Emm, a long time for this issue, but I tested a moment ago, I think the bug already fixed in #707 . |
Member
|
We'll close this for now then 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
message bubble backgroundColor would deranged that operation the same as #448