Fixed MessagesCollectionView's bottom inset when hardware keyboard is…#707
Merged
SD10 merged 9 commits intoMessageKit:developmentfrom Jun 1, 2018
Merged
Fixed MessagesCollectionView's bottom inset when hardware keyboard is…#707SD10 merged 9 commits intoMessageKit:developmentfrom
SD10 merged 9 commits intoMessageKit:developmentfrom
Conversation
MessageKit 1.0-beta
…-view Update FAQ how to hide AvatarView
Update VISION.md for networking/caching beliefs
Make LabelAlignment initializer public
SD10
reviewed
May 31, 2018
|
|
||
| messageCollectionViewBottomInset = afterBottomInset | ||
|
|
||
| guard !isMessagesControllerBeingDismissed else { return } |
Member
There was a problem hiding this comment.
@zhongwuzw Ok, I can see how this fixes the dismissal in #562. How does this also solve the hardware keyboard in #690?
Member
Author
There was a problem hiding this comment.
@SD10 Another way to calculate the bottomInset.
Member
|
Sorry, GitHub UI malfunction 😂 @zhongwuzw do you think we could point this at |
Closed
Member
Author
|
@SD10 It's ok, not big bug. I'll switch to |
Member
|
@zhongwuzw Great thanks 👌 We have to do a better job of keeping |
This was referenced Jul 9, 2018
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #568 .
Fixed #562 , Fixed #690 .