[Fix] Fixed separator setting line height#578
Closed
AndriiPetrovDev wants to merge 1 commit intoMessageKit:developmentfrom
Closed
[Fix] Fixed separator setting line height#578AndriiPetrovDev wants to merge 1 commit intoMessageKit:developmentfrom
AndriiPetrovDev wants to merge 1 commit intoMessageKit:developmentfrom
Conversation
Member
|
@AndrewPetrov I’m not sure why we’re making this change? cc @nathantannar4 Sent with GitHawk |
Author
|
constraint height to 1 prevents separator to change height. And also I changed vertical position constraint to free change separator height and don't touch other internal stuff |
zhongwuzw
requested changes
Mar 21, 2018
|
|
||
| // The constraints within the MessageInputBar | ||
| separatorLine.addConstraints(topAnchor, left: leftAnchor, right: rightAnchor, heightConstant: 1) | ||
| separatorLine.addConstraints(left: leftAnchor, bottom: topStackView.topAnchor, right: rightAnchor) |
Member
There was a problem hiding this comment.
Thanks for your fix, please update the commit to just remove height constraint. Because topStackView has topStackViewPadding, we need to tie the separator to the top of messageInputBar.
separatorLine.addConstraints(topAnchor, left: leftAnchor, right: rightAnchor)
Member
|
@AndrewPetrov Any update on the requested changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
fix separator line constraints
Does this close any currently open issues?
#446
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Devices/Simulators:
iPhone 8 plus
iOS Version:
11.2
Swift Version:
4
MessageKit Version:
0.13.1