Fixed separator line height#667
Merged
zhongwuzw merged 2 commits intoMessageKit:developmentfrom Apr 30, 2018
Merged
Conversation
SD10
reviewed
Apr 30, 2018
|
|
||
| // The constraints within the MessageInputBar | ||
| separatorLine.addConstraints(topAnchor, left: leftAnchor, right: rightAnchor, heightConstant: 1) | ||
| separatorLine.addConstraints(topAnchor, left: leftAnchor, right: rightAnchor) |
Member
There was a problem hiding this comment.
Does this change the default appearance?
idanzhu
pushed a commit
to idanzhu/MessageKit
that referenced
this pull request
Jun 5, 2018
* upstream/master: (113 commits) Rewrite issue template to a HTML comment Make LabelAlignment initializer public Update FAQ how to hide AvatarView Update VISION.md for networking/caching beliefs Release 1.0.0-beta.1 Remove old docs and update quickstart Fixed separator line height (MessageKit#667) Revert .bottom change and remove arg Add another entry and update example Add CHANGELOG entry Fix failing tests Rename cellBottomLabel Fix cellContentHeight calculations Add cellTop/messageLabelTop/cellBottom case for avatar vertical position Add cellTopLabel and rename topLabel to messageTopLabel Renamed MessageData to MessageKind Remove NSAttributedString height(considering) extention method Reduce the number of calculation for label size Update Example swiftlint config Fix ChatExample for SwiftLint ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #578 , fixed #446 .