Double the font size of emoji messages#795
Merged
SD10 merged 2 commits intoMessageKit:masterfrom Aug 2, 2018
Vortec4800:emoji-size
Merged
Double the font size of emoji messages#795SD10 merged 2 commits intoMessageKit:masterfrom Vortec4800:emoji-size
SD10 merged 2 commits intoMessageKit:masterfrom
Vortec4800:emoji-size
Conversation
Modifies the emoji size calculator to set a new font, which has a size that is double the size of the default font.
Member
|
@Vortec4800 Can you add a CHANGELOG entry for this? Under the Changed section of Upcoming Release? See the other entries for the proper format |
SD10
approved these changes
Aug 2, 2018
Member
SD10
left a comment
There was a problem hiding this comment.
Thanks for taking the time to improve this @Vortec4800 💯
Member
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the emoji size calculator to set a new font, which has a size that is double the size of the default font.
What does this implement/fix? Explain your changes.
This re-instates old functionality where Emoji messages would have a larger font size.
Does this close any currently open issues?
This is related to issue #794
Any other comments?
This seemed like the best way/place to do this, although if you have a better place or method of setting this I would be happy to refactor.
Where has this been tested?
Devices/Simulators: iPhone 8 simulator, iPhone X device
iOS Version: iOS 11.4 and iOS 12 beta 5
Swift Version: Swift 4
MessageKit Version: 1.0.0