Skip to content

[BLOCKED] Release MessageKit v1.1.0#818

Closed
SD10 wants to merge 67 commits intomasterfrom
development
Closed

[BLOCKED] Release MessageKit v1.1.0#818
SD10 wants to merge 67 commits intomasterfrom
development

Conversation

@SD10
Copy link
Member

@SD10 SD10 commented Aug 15, 2018

Changed

  • Fixed the way that the Strings and UIImages are parsed in the InputTextView to prevent crashes in parseForComponents().
    #791 by @nathantannar4

Added

  • Added support for detection and handling of NSLinks inside of messages.
    #815 by @jnic

  • Added customizable accessoryView, with a new MessagesDisplayDelegate function configureAccessoryView, and corresponding size & padding properties in MessageSizeCalculator.
    #710 by @hyouuu

  • Added additionalBottomInset property that allows to adjust the bottom content inset automatically set on the messages collection view by the view controller.
    #787 by @andreyvit

Fixed

  • Fixed bottom content inset adjustment when using an undocked keyboard on iPad, or when edgesForExtendedLayout does not include .top, or when a parent container view controller adds extra views at the top of the screen.
    #787 by @andreyvit

  • Fixed the MessageData.emoji case to use 2x the messageLabelFont size by default.
    #795 by @Vortec4800.

TODO:

  • Update podspec
  • Update CHANGELOG header

tinder-sgong and others added 30 commits June 2, 2018 02:10
Add customizable accessoryView besides messageContainer
This change provides better handling of keyboard frames. It copes with different values of UIViewController.edgesForExtendedLayout, UIScrollView.contentInsetAdjumentBehavior, view controller containment scenarios and undocked keyboards, and uses cleaner code.

Improvements and fixes in this change:

1. Translates keyboard frame from screen coordinates into view controller coordinates. They aren’t the same thing when containment is involved, or edgesForExtendedLayout does not include .top.

2. Avoids special casing any iPhone models and avoids dealing with safeAreaInsets manually. In iOS 11, UIScrollView may behave differently depending on contentInsetAdjumentBehavior, and the old code incorrectly assumed that the mode is .always (while it is in fact is .automatic) and that no extra safe area insets have been introduced at the bottom edge. Best part, we don’t have to deal with any of this at all, we can offload the logic to UIScrollView itself by looking at the difference between adjustedContentInset and contentInset.

3. Handles view controller containment and undocked keyboards by taking into account an intersection of the scroll view frame and the keyboard’s frame. I think Apple demoes this in one of the WWDC videos, but I couldn’t find which one (or if I’m misremembering). Regardless, this technique makes sure we compute and use a sensible number.

There’s also a couple of extra renames that make the intention of the modified code clearer.
Adjust contentInset for the keyboard frame properly
SD10 and others added 6 commits September 11, 2018 21:09
…with-coder

Enhancement/init reusable view with coder
Fix scrollsToBottomOnKeybordBeginsEditing typo (development branch)
* Remove MessageInputBar files and change build settings

* Conditional imports to allow for builds without MessageInputBar

* Update Cardfile

* Specify Version in Cartfile for MessageInputBar

* Remove conditional imports in favor of Carthage for local development

* Additional `import MessageInputBar`

* Remove `MessageInputBar` from Cartfile.private

* Bump MessageInputBar version

* Add Cartfile

* Tweak build settings

* Specify import of MessageInputBar for Carthage
@SD10
Copy link
Member Author

SD10 commented Sep 18, 2018

Blocked by MessageKit/MessageInputBar#10

nathantannar4 and others added 21 commits September 25, 2018 23:04
fix intrinsic content size for MessageLabel
…eViewController. Moreover, there is an easier method to find the visible section.

It is unnecessary to scroll to the bottom when title view updated.
Example chat screens do not scroll to the bottom on new message insertion.
Add didTapAccessoryView Delegate method and adjust layout
…ayButton Views, MessageContent, MessageCollectionView Cells, MessagesCollectionViewFlow Layout.
Fix: Allow required initializator methods @ Views.
@SD10
Copy link
Member Author

SD10 commented Oct 14, 2018

Lets close this in favor of #910

@SD10 SD10 closed this Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants