Add support for embedded NSLinks for .url DetectorType#815
Merged
SD10 merged 2 commits intoMessageKit:masterfrom Aug 15, 2018
Merged
Add support for embedded NSLinks for .url DetectorType#815SD10 merged 2 commits intoMessageKit:masterfrom
SD10 merged 2 commits intoMessageKit:masterfrom
Conversation
Add support for embedded NSLinks for .url DetectorType
SD10
approved these changes
Aug 15, 2018
Member
|
I'll add the CHANGELOG entry when I do the release. Thanks for this 👍 |
Member
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
This was referenced Aug 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The existing data detector types are manually parsed via
NSDataDetector, which means we lose support for embeddedNSLinks in attributed strings.This change adds support for these, enabled when
DetectorType.urlis set in the delegate for consistency with existing data detectors. These are supported in addition to the current behaviour 👻Does this close any currently open issues?
#609
Where has this been tested?
Devices/Simulators: iPhone X, iPhone SE
iOS Version: 11
Swift Version: 4.1
MessageKit Version: HEAD of master