cmov: add support for NonZero and Ordering#1404
Merged
Conversation
Adds `Cmov` and `CmovEq` impls for the following types (and slices thereof) from `core::num`: - NonZeroI8 - NonZeroI16 - NonZeroI32 - NonZeroI64 - NonZeroI128 - NonZeroU8 - NonZeroU16 - NonZeroU32 - NonZeroU64 - NonZeroU128 Also adds support to `core::cmp::Ordering`. This should be sufficient to eliminate unsafe code from `ctutils`, and also improve performance.
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2026
In #1404 impls of `Cmov` and `CmovEq` were added to the `NonZero*` and `Ordering` types and slices thereof, which is what the unsafe code in `ctutils` existed to handle. Now they can be handled like the other types `cmov` already has trait impls for. And with that, we can remove all of the unsafe code in this crate, with all of it having been factored into the `cmov` crate, which makes that the one place to look for `unsafe` auditing. With all the `unsafe` removed, this also adds `forbid(unsafe_code)`.
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2026
In #1404 impls of `Cmov` and `CmovEq` were added to the `NonZero*` and `Ordering` types and slices thereof, which is what the unsafe code in `ctutils` existed to handle. Now they can be handled like the other types `cmov` already has trait impls for. And with that, we can remove all of the unsafe code in this crate, with all of it having been factored into the `cmov` crate, which makes that the one place to look for `unsafe` auditing. With all the `unsafe` removed, this also adds `forbid(unsafe_code)`.
Merged
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2026
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2026
In #1404 impls of `Cmov` and `CmovEq` were added to the `NonZero*` and `Ordering` types and slices thereof, which is what the unsafe code in `ctutils` existed to handle. Now they can be handled like the other types `cmov` already has trait impls for. And with that, we can remove all of the unsafe code in this crate, with all of it having been factored into the `cmov` crate, which makes that the one place to look for `unsafe` auditing. With all the `unsafe` removed, this also adds `forbid(unsafe_code)`.
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2026
In #1404 impls of `Cmov` and `CmovEq` were added to the `NonZero*` and `Ordering` types and slices thereof, which is what the unsafe code in `ctutils` existed to handle. Now they can be handled like the other types `cmov` already has trait impls for. And with that, we can remove all of the unsafe code in this crate, with all of it having been factored into the `cmov` crate, which makes that the one place to look for `unsafe` auditing. With all the `unsafe` removed, this also adds `forbid(unsafe_code)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CmovandCmovEqimpls for the following types (and slices thereof) fromcore::num:Also adds support to
core::cmp::Ordering.This should be sufficient to eliminate unsafe code from
ctutils, and also improve performance.