ctutils: use new cmov trait impls; remove unsafe#1405
Merged
Conversation
0b8fd74 to
f80984e
Compare
In #1404 impls of `Cmov` and `CmovEq` were added to the `NonZero*` and `Ordering` types and slices thereof, which is what the unsafe code in `ctutils` existed to handle. Now they can be handled like the other types `cmov` already has trait impls for. And with that, we can remove all of the unsafe code in this crate, with all of it having been factored into the `cmov` crate, which makes that the one place to look for `unsafe` auditing. With all the `unsafe` removed, this also adds `forbid(unsafe_code)`.
f80984e to
94f8a30
Compare
Merged
tarcieri
added a commit
that referenced
this pull request
Jan 20, 2026
## Added - `core::num::NonZero<T>` support (#1368) - Pluggable trait impls for `[T]` and `[T; N]` with helper traits: (#1388) - `CtAssign`: `CtAssignSlice` - `CtEq`: `CtEqSlice` - `CtSelect`: `CtSelectArray` - `CtSelectUsingCtAssign` marker trait (#1391) ## Changed - Split `CtAssign` out of `CtSelect` (#1363) - Bump `cmov` to v0.5 (#1386) ## Removed - `BytesCtEq`/`BytesCtSelect` no longer needed because default `[u8]` impls are fast (#1376) - `target_pointer_width` gating (#1389) - `unsafe` code (#1405)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1404 impls of
CmovandCmovEqwere added to theNonZero*andOrderingtypes and slices thereof, which is what the unsafe code inctutilsexisted to handle.Now they can be handled like the other types
cmovalready has trait impls for.And with that, we can remove all of the unsafe code in this crate, with all of it having been factored into the
cmovcrate, which makes that the one place to look forunsafeauditing.With all the
unsaferemoved, this also addsforbid(unsafe_code).