merge: optimize the countVowels algo#886
Merged
raklaptudirm merged 7 commits intoTheAlgorithms:masterfrom Feb 17, 2022
fahimfaisaal:dev-string
Merged
merge: optimize the countVowels algo#886raklaptudirm merged 7 commits intoTheAlgorithms:masterfrom fahimfaisaal:dev-string
raklaptudirm merged 7 commits intoTheAlgorithms:masterfrom
fahimfaisaal:dev-string
Conversation
simplify the algo by using regex and String.prototype.match method, and modified the JS Doc
raklaptudirm
requested changes
Feb 16, 2022
ignore the useless traverse in best case by the help of regex and String.prototype.replace method
This reverts commit 4609833.
Contributor
Author
|
Mistakenly I have pushed the last two commits, that's why I revert that. I'll add again this in the next pull request. |
raklaptudirm
requested changes
Feb 17, 2022
Member
raklaptudirm
left a comment
There was a problem hiding this comment.
Format your code with standard.js.
Contributor
Author
|
Done ✅ |
raklaptudirm
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to JavaScript community
Describe your change:
Checklist: