Skip to content

merge: optimize the countVowels algo #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 7 commits into from
Feb 17, 2022
Merged

merge: optimize the countVowels algo #886

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2822e1
pref: optimize the count vowels algo
fahimfaisaal Feb 16, 2022
ae99515
fix: resolve all requests
fahimfaisaal Feb 17, 2022
6f401c9
pref: optimize the algo by regex
fahimfaisaal Feb 17, 2022
4609833
test: add four new test cases
fahimfaisaal Feb 17, 2022
9a80be6
Merge branch 'dev-string' of github.com:fahimfaisaal/Javascript into …
fahimfaisaal Feb 17, 2022
06b7e3e
Revert "test: add four new test cases"
fahimfaisaal Feb 17, 2022
14eec5d
style: fromat with standard js
fahimfaisaal Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions String/CountVowels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/**
* @function countVowels
* @description Given a string of words or phrases, count the number of vowels.
* @param {String} url - The input string
* @return {Number} count
* @param {String} str - The input string
* @return {Number} - The number of vowels
* @example countVowels("ABCDE") => 2
* @example countVowels("Hello") => 2
*/
Expand All @@ -11,15 +11,11 @@ const countVowels = (str) => {
if (typeof str !== 'string') {
throw new TypeError('Input should be a string')
}
const vowels = new Set(['a', 'e', 'i', 'o', 'u'])
let count = 0
for (let i = 0; i < str.length; i++) {
const char = str[i].toLowerCase()
if (vowels.has(char)) {
count++
}
}
return count

const vowelRegex = /[aeiou]/gi
const vowelsArray = str.match(vowelRegex) || []

return vowelsArray.length
}

export { countVowels }