-
Notifications
You must be signed in to change notification settings - Fork 230
Update gh pages #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Update gh pages #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow more than 2 digits for extremely long videos - Although the spec says it must be 2+ and so single digit times (e.g. 1:02:24.000 --> 1:04:48.000) are invalid, allow these too as it's unambiguous what was intended and easy to handle
This makes some colors more consistent, fixes a handful of missing hover/focus states, removes floats and replaces with grid/flex, and evens out a number of design characteristics. See #647
If the `kind` attribute is not set, the default value is `subtitles`. If omitted, set to `subtitles`. Also check tracks without the kind attribute when assessing whether a transcript is posible. Fixes #618
Avoids having the extra HTTP call to load an otherwise unneeded img. Adds styling to decrease the importance and provide a bit more separation between control groups. Makes custom styling easier. Good change to have along with the new skin for 4.7. Fixes #550
Bumps [form-data](https://github.com/form-data/form-data) from 4.0.2 to 4.0.4. - [Release notes](https://github.com/form-data/form-data/releases) - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.2...v4.0.4) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…data-4.0.4 Bump form-data from 4.0.2 to 4.0.4
The API no longer exists, and the Git history is sufficient documentation.
Not used, but make options.
This is mostly so that we're not mixing setting tracks with getting duration.
This note is only relevant to iOS prior to version 6; iOS 7 was released in 2013. As far as I can tell, this is no longer true: the container is wrapped identically between video and audio.
VTT parsing - Allow hour section that isn't 2 digits
This does not appear to be used, and I don't see any reason for it to be.
Using ternaries for simple if/else cases simplifies code.
Mostly a style preference, but also reviewed all statements and changed to ternary where appropriate.
This reduces the size of the un-minified dist file by about 30%, which makes the difference between .dist and main file much more significant.
See #314 Works; need to verify that the syncing is accurate.
…oved yesterday...
Fixes #663. Also changes input controls to type="number" so arrow keys can be used to change values. Also changes to use outerHeight so that margins are included.
…ing or encoding Use a regex so that all new lines are replaced with br in lyrics mode. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Merge develop into main for beta 1 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main to gh pages