@jayapalu There is another PR out there for config drive enhancements you may want to check out and review - #2097

@jayapalu - So this seems to be a resubmit of #938.
Can you please refer to the comments in the previous PR for review?

Thanks.

@pedro-martins @kiwiflyer
moved the code into method. vmdata is checked for not null in the resource for attaching the config drive iso to vm.
@kiwiflyer I am following #2097, thanks for the info.

ACS CI BVT Run

Sumarry:
Build Number 733
Hypervisor xenserver
NetworkType Advanced
Passed=57
Failed=5
Skipped=5

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

• test_non_contigiousvlan.py

• test_extendPhysicalNetworkVlan Failing since 2 runs

• test_routers_network_ops.py

• test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed

• test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed

• test_03_RVR_Network_check_router_state Failed

• ContextSuite context=TestRedundantIsolateNetworks>:teardown Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_over_provisioning.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py

reviewer please see #938 as well when reviewing this

Failed tests are not related to this PR.
Can some one please review this PR.
@borisstoyanov Can you also trigger the Trillian.

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-745

@blueorangutan test

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1131)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33583 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2116-t1131-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 49 look ok, 2 have error(s)

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1398

@jayapalu In PR #2097 we created a new UserData provider to have the possibility to have UserData without VR. Is an advanced setting still needed in that case? It would then be based upon the NetworkOffering.

Ping @jayapalu

@fmaximus did you already incorporate the changes here, maybe except the setting part? In case you did we can close this one.

@DaanHoogland @fmaximus @jayapalu ping, can you comment if this PR was already included in any other PR, or we still need this PR towards the config drive feature?

@rhtyd I don't see anything in this PR that is needed given other ConfigDrive functionality submitted in different PRs, awaitning responses from @jayapalu and @fmaximus

@DaanHoogland okay, removed this PR from 4.11.1.0 milestone based on your comment.

@rhtyd thanks. I still want comments from @jayapalu and @fmaximus and maybe @kiwiflyer

@jayapalu I'm closing this, please rebase and re-open if it is still relevant