CLOUDSTACK-8959: Option to attach the config drive.#938
CLOUDSTACK-8959: Option to attach the config drive.#938kansal wants to merge 1 commit intoapache:masterfrom
Conversation
|
Hi. |
There was a problem hiding this comment.
@kansal Could you please correct the "Migrateommand" to "MigrateCommand"? Thanks.
|
Ping @kansal. Could you take a look at @pedro-martins's and @GabrielBrascher's suggestions? They seem worth it to me... Also, if you do, please go ahead and rebase this PR to the current master. Thanks :) |
| "The default lable name for the config drive", false); | ||
|
|
||
| static final ConfigKey<Boolean> ConfigDriveCreation = new ConfigKey<Boolean>("Advanced", Boolean.class, "use.config.drive", "true", | ||
| "If true, use config drives for data transfer else don't use. Default is true", true); |
There was a problem hiding this comment.
Explain why this should be true/enabled by default?
|
@kansal please rebase against master and push -f, and update on status of your PR, thanks |
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests: Skipped tests: Passed test suits: |
|
Please see 2116. |
Config Drive was added as a part of DNS/DHCP offload feature. The main aim was to provide a way to send user data to VM instances in case of no Virtual Routers. The present implementation checks for the case when there is no service available in Network offering. This leads to attaching of config drives even in the case when user doesn’t want to send the data to VM instances. Providing a way so that attaching config drives is optional can solve this.
Added a global setting(which is by default true) to make sure that users have a choice to attach the config drives.