Skip to content

CLOUDSTACK-8971 - Improve the current test_privategw_acls.py#957

Merged
asfgit merged 1 commit intoapache:masterfrom
artificially-ai:fix/privategw_acl-CLOUDSTACK-8971
Oct 21, 2015
Merged

CLOUDSTACK-8971 - Improve the current test_privategw_acls.py#957
asfgit merged 1 commit intoapache:masterfrom
artificially-ai:fix/privategw_acl-CLOUDSTACK-8971

Conversation

@wilderrodrigues
Copy link
Contributor

@wilderrodrigues wilderrodrigues commented Oct 20, 2015

  • Read cofiguration from the zone: template id; template id; and domain id
  • Create Account and VPC Offering
  • Add cleanup resources

@wilderrodrigues
Copy link
Contributor Author

wilderrodrigues commented Oct 20, 2015

Ping @remibergsma @michaelandersen @miguelaferreira @karuturi @DaanHoogland @wido

Test results:

test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 301.406s

OK

@borisroman
Copy link
Contributor

borisroman commented Oct 20, 2015

@wilderrodrigues Ran tests. OK.

=== TestName: test_privategw_acl | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 250.320s

OK

LGTM, pending Travis ofcourse...

@wilderrodrigues
Copy link
Contributor Author

wilderrodrigues commented Oct 20, 2015

Thanks, @borisroman !

Cheers,
Wilder

@michaelandersen
Copy link

michaelandersen commented Oct 20, 2015

LGTM!

@remibergsma
Copy link
Contributor

remibergsma commented Oct 20, 2015

@michaelandersen Can you please let us know what you tested / reviewed? Thanks!

@wilderrodrigues wilderrodrigues changed the title CLOUDSTACK-8933 - Improve the current test_privategw_acls.py CLOUDSTACK-8971 - Improve the current test_privategw_acls.py Oct 20, 2015
@wilderrodrigues
Copy link
Contributor Author

wilderrodrigues commented Oct 20, 2015

@remibergsma @michaelandersen

I added the wrong ACS issue to the PR title and the commit. I already edited the title, will now amend the commit and force push. Sorry for that!

Cheers,
Wilder

@wilderrodrigues
CLOUDSTACK-8971 - Improve the current test_privategw_acls.py
8708d0d 
   - Read cofiguration from the zone: template id; template id; and domain id
   - Create Account and VPC Offering
   - Add cleanup resources
@michaelandersen
Copy link

michaelandersen commented Oct 20, 2015

@remibergsma @wilderrodrigues LGTM'ed this one too soon, was a bit too enthusiastic. sorry about that. Ran the test just now, but it's failing!

nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=../../../mct-zone1-kvm1.cfg -a tags=advanced,required_hardware=false test_privategw_acl.py

=== Marvin Init Logging Successful===
Creating Admin Account for Domain ID ==> 01634a5a-726d-11e5-9395-5254001daa62
Creating a VPC offering..
Enabling the VPC offering created
Creating a VPC network in the account: test-TestPrivateGwACL-test_privategw_acl-KZ68F5
cCreate NetworkOffering
Created and Enabled NetworkOffering
Adding Network={'netmask': '255.255.255.0', 'displaytext': 'Test Network', 'name': 'NETWORK-10.1.1.1'}
Created network with ID: b8914c96-9a92-4bbb-8e6b-51b1ed74a803
===final results are now copied to: /tmp/marvin//MarvinLogs/test_privategw_acl_GYMPT8===

test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : FAILED ===
FAIL

Traceback (most recent call last):
File "/Users/mandersen/Projects/cloudstack/test/integration/smoke/test_privategw_acl.py", line 199, in test_privategw_acl
self.createPvtGw()
File "/Users/mandersen/Projects/cloudstack/test/integration/smoke/test_privategw_acl.py", line 275, in createPvtGw
self.fail("Failed to create Private Gateway ==> %s" % e)
AssertionError: Failed to create Private Gateway ==> Execute cmd: createprivategateway failed, due to: errorCode: 530, errorText:None
-------------------- >> begin captured stdout << ---------------------
=== TestName: test_privategw_acl | Status : FAILED ===

@michaelandersen
Copy link

michaelandersen commented Oct 20, 2015

from the mgt server log:
WARN [c.c.a.d.ParamGenericValidationWorker](709693495@qtp-265638379-0:ctx-dfba94e8 ctx-8090674b ctx-c8da340d) Received unknown parameters for command createNetworkACL. Unknown p
arameters : cidr
INFO [o.a.c.f.j.i.AsyncJobMonitor](API-Job-Executor-5:ctx-8ec951c2 job-1957) Add job-1957 into job monitoring
WARN [c.c.a.d.ParamGenericValidationWorker](API-Job-Executor-5:ctx-8ec951c2 job-1957 ctx-173033b6) Received unknown parameters for command createNetworkACL. Unknown parameters :
cidr
INFO [o.a.c.f.j.i.AsyncJobMonitor](API-Job-Executor-5:ctx-8ec951c2 job-1957) Remove job-1957 from job monitoring
WARN [c.c.a.d.ParamGenericValidationWorker](709693495@qtp-265638379-0:ctx-f8a13dcf ctx-86f02aa9 ctx-57be2ff6) Received unknown parameters for command createNetworkOffering. Unkn
own parameters : usevpc
ERROR [c.c.a.ApiServer](709693495@qtp-265638379-0:ctx-ac06c612 ctx-aacaf035 ctx-2f37a8d5) unhandled exception executing api command: [Ljava.lang.String;@9976afa
java.lang.NullPointerException
at com.cloud.network.vpc.VpcManagerImpl.createVpcPrivateGateway(VpcManagerImpl.java:1610)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at com.sun.proxy.$Proxy148.createVpcPrivateGateway(Unknown Source)
at org.apache.cloudstack.api.command.admin.vpc.CreatePrivateGatewayCmd.create(CreatePrivateGatewayCmd.java:150)

@remibergsma
Copy link
Contributor

remibergsma commented Oct 20, 2015

It works fine for me:

nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false smoke/test_privategw_acl.py

Result:

test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 223.325s

OK

Based on the above: LGTM

@michaelandersen are you sure it isn't a local problem? Maybe try to deploy again? I'll hold this PR until tomorrow morning.

@wilderrodrigues
Copy link
Contributor Author

wilderrodrigues commented Oct 21, 2015

@michaelandersen

Could you give some details on how you executed the tests? It looks like env issues.

Did you...

  • checked out the PR
  • built ACS and RPMs
  • installed RPMs on KVM
  • cleaned the DB
  • deployed DC
  • ran the tests

...?

Or was it executed towards an existing/running environment?

As you can see in the Python stack trace, it says errorTest: None

AssertionError: Failed to create Private Gateway ==> Execute cmd: createprivategateway failed, due to: errorCode: 530, errorText:None

When you ran it, were the templates ready? Could you please follow steps above and try again? I will also try on my side.

Cheers,
Wilder

@wilderrodrigues
Copy link
Contributor Author

wilderrodrigues commented Oct 21, 2015

@remibergsma @michaelandersen

Environment:

Management Server + MySQL on CentOS 7.1
Agent + Common built form source
1 KVM host on CentOS 7.1

New results:

test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 243.665s

OK
/tmp//MarvinLogs/test_privategw_acl_4TCQBF/results.txt (END)

Cheers,
Wilder

@michaelandersen
Copy link

michaelandersen commented Oct 21, 2015

yes @wilderrodrigues it is most likely an environment issue. don't wait on me for this PR.

@asfgit asfgit merged commit 8708d0d into apache:master Oct 21, 2015
asfgit pushed a commit that referenced this pull request Oct 21, 2015
@remibergsma
Merge pull request #957 from ekholabs/fix/privategw_acl-CLOUDSTACK-8971
260ce75 
CLOUDSTACK-8971 - Improve the current test_privategw_acls.py   - Read cofiguration from the zone: template id; template id; and domain id
   - Create Account and VPC Offering
   - Add cleanup resources

* pr/957:
  CLOUDSTACK-8971 - Improve the current test_privategw_acls.py

Signed-off-by: Remi Bergsma <github@remi.nl>
@miguelaferreira miguelaferreira mentioned this pull request Oct 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wilderrodrigues @borisroman @michaelandersen @remibergsma @asfgit