Improve marvin test site2site VPN#952
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 22, 2015
Merged
Conversation
Author
|
run with: |
1cbb572 to
24e5d16
Compare
Contributor
|
Thanks, @michaelandersen I will have a look at this one today! Cheers, |
Contributor
|
@michaelandersen Thank you! Can you please rebase with current master? Will test it afterwards :-) |
24e5d16 to
a37f9c5
Compare
Contributor
|
Testing this one now! |
d4eb4b7 to
b00ecbc
Compare
Add optional fields: iprange and fordisplay to Marvin base.py class method Vpn.create
Add optional field: passive to Marvin base.py class method Vpn.createVpnConnection
b00ecbc to
e2d1313
Compare
Contributor
|
Run the tests and it LGTM 👍 Thanks for this PR, @michaelandersen Cheers, |
Contributor
|
Please have a look at Jenkins and/or force push to trigger another run. |
Author
|
@remibergsma: why another run? Jenkins (and travis) is green |
Contributor
|
Ping @remibergsma @karuturi @DaanHoogland @borisroman @wido @bhaisaab @miguelaferreira @michaelandersen @bvbharat @Runseb @terbolous This is a test: no java/python/shell code changes. Could someone please try to run it so we can get a 2nd LGTM and merge it? Since we need more tests, this will fit like a glove. :) Thanks in advance. Cheers, |
Contributor
|
@wilderrodrigues running it now (together with a bunch of other tests). I'll report the results tomorrow. |
Contributor
|
I ran the test against master with additional PRs (#952, #958, #951, #957, #940) and the result was this: <?xml version="1.0" encoding="UTF-8"?>
<testsuite name="nosetests" tests="2" errors="0" failures="0" skip="0">
<testcase classname="integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn" name="test_vpc_remote_access_vpn" time="1696.270"></testcase>
<testcase classname="integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn" name="test_vpc_site2site_vpn" time="1268.090">
<system-err>
<![CDATA[====Trying SSH Connection: Host:192.168.23.6 User:root Port:22 RetryCnt:10===
===SSH to Host 192.168.23.6 port : 22 SUCCESSFUL===
{Cmd: /bin/ping -c 3 -t 10 10.1.1.165 |grep packet|cut -d ' ' -f 7| cut -f1 -d'%' via Host: 192.168.23.6} {returns: [u'0']}
]]>
</system-err>
</testcase>
</testsuite>I'm not sure if the result is I don't have the full Marvin log because my build failed to archive those. |
Author
|
thanks for testing @miguelaferreira. and @wilderrodrigues for chasing this pr |
Contributor
|
did the check-pr test on this one but faied rerunning to further investigate |
Contributor
|
The system-err is because the Marvin code prints all the ssh commands to the terminal. It doesn't mean it failed. All the SSH related tests will print a huge amount of data on the terminal. :( @DaanHoogland: but what kind of error did you get? Is it environment related? Cheers, |
Contributor
|
That's what I thought. The JUnit report plugin in Jenkins sais the test passed. (See last line of table in picture)
I'm running a new build at the moment, and hopefully that will archive the full marvin logs. |
Contributor
|
@wilderrodrigues I think it was, in the end I ran only the smoke test suite and even that got errors so please ignore for this PR |
Contributor
|
New test run, same result: 👍 LGTM |
Author
|
The exceptions: |
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2015
Improve marvin test site2site VPNAdd optional fields: iprange and fordisplay to Marvin base.py class method Vpn.create Add optional field: passive to Marvin base.py class method Vpn.createVpnConnection * pr/952: Improve marvin test site2site VPN Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional fields: iprange and fordisplay to Marvin base.py class method Vpn.create
Add optional field: passive to Marvin base.py class method Vpn.createVpnConnection