cloud-apidoc module depends on cloud-client-ui#958
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 22, 2015
Merged
Conversation
Contributor
Author
|
ping @DaanHoogland this is the error you were asking me about right? |
Contributor
|
@miguelaferreira , yes this is one of the obstakels I encountered the last few days. |
Contributor
|
I built ACS and the RPMs based on this PR, with 4 threads - as suggested in @miguelaferreira's comment. All worked fine! LGTM 👍 Cheers, |
Contributor
ran all tests with three errors in "Test VPC offering without ...". those are not related.Ran 40 tests in 7302.424s FAILED (errors=3) |
Contributor
|
LGTM 👍 -T2C == two threads per core. |
Contributor
|
@miguelaferreira Can you please force push to have Jenkins run again? Will merge once it succeeds, or when we are OK with it not being successful. |
Contributor
|
Error is not related anyway: |
9f9f6a2 to
9cbd321
Compare
asfgit
pushed a commit
that referenced
this pull request
Oct 22, 2015
…cloud-client-ui
cloud-apidoc module depends on cloud-client-uiWhen building the cloud-apidoc module a script called `./build-apidoc.sh` is executed with an argument that points to `../../client/target/cloud-client-ui-${project.version}/WEB-INF/lib`. The script uses that argument to build a Java classpath. However, since the cloud-apidoc module does not explicitly depend on cloud-client-ui, a parallel maven build will often fail because the required jars are not present when needed.
Error message when build fails:
```
Error: Could not find or load main class com.cloud.api.doc.ApiXmlDocWriter
```
This PR makes the dependency explicit.
Resulting build:
```
mvn clean install -T4 -Pdeveloper,systemvm
....
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:02 min (Wall Clock)
[INFO] Finished at: 2015-10-20T13:31:30+02:00
[INFO] Final Memory: 98M/1526M
[INFO] ------------------------------------------------------------------------
```
* pr/958:
cloud-apidoc module depends on cloud-client-ui
Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the cloud-apidoc module a script called
./build-apidoc.shis executed with an argument that points to../../client/target/cloud-client-ui-${project.version}/WEB-INF/lib. The script uses that argument to build a Java classpath. However, since the cloud-apidoc module does not explicitly depend on cloud-client-ui, a parallel maven build will often fail because the required jars are not present when needed.Error message when build fails:
This PR makes the dependency explicit.
Resulting build: