Oneapi lapack #3389
Merged
Oneapi lapack #3389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
requested changes
Apr 3, 2023
Member
umar456
left a comment
There was a problem hiding this comment.
Looks like you are still working on this PR. I left a few comments but I think you know about most of them.
umar456
reviewed
Apr 5, 2023
umar456
reviewed
Apr 5, 2023
8e3fdb7 to
d56857d
Compare
umar456
approved these changes
Apr 6, 2023
umar456
previously approved these changes
Apr 6, 2023
umar456
previously approved these changes
Apr 6, 2023
umar456
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several missing lapack functions - svd, cholesky, lu to the oneapi backend, as well as the identity kernel required for the svd tests.
Description
Tests also rely on blas functions in outstanding blas PR.
Checklist