Resolve addon file paths correctly in CLI >= 2.12#127
Merged
RobbieTheWagner merged 1 commit intoember-cli-code-coverage:masterfrom Oct 1, 2017
Merged
Resolve addon file paths correctly in CLI >= 2.12#127RobbieTheWagner merged 1 commit intoember-cli-code-coverage:masterfrom
RobbieTheWagner merged 1 commit intoember-cli-code-coverage:masterfrom
Conversation
Collaborator
|
@dfreeman could we use ember-try and run coverage reports and check that things are renamed as expected? Aside from that, we could probably just do a quick test that passing the different file names yields the expected results here. Would definitely like at least a test that ensures the regex works as intended, if not some sort of full test. |
Contributor
Author
|
Unfortunately ember-try doesn't support swapping out versions of the CLI itself, but I can definitely add unit test coverage at least — I think I missed that this repo had a node-land test suite when I originally wrote this. |
Collaborator
|
@dfreeman yeah, any sort of node tests to just lightly check this you can add would be fantastic, and then I will gladly merge 😄 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in (I believe) ember-cli@2.12, addon files stopped being nested under
modules/, which means the path correction logic here wasn't working properly for them.If you have thoughts on the best way to test this change, I'd welcome them 🙂