Typescript initial support#144
Closed
igbopie wants to merge 9 commits intoember-cli-code-coverage:masterfrom
Closed
Typescript initial support#144igbopie wants to merge 9 commits intoember-cli-code-coverage:masterfrom
igbopie wants to merge 9 commits intoember-cli-code-coverage:masterfrom
Conversation
added 2 commits
November 14, 2017 15:46
Author
|
Yes, not all test are passing. The reason is that inline source map is not generated on those cases. I have to figure out how, or may don't even read src map in that case. |
Collaborator
|
In general, we should avoid landing large changes to master until after #141 has landed... |
Author
|
Sounds good! |
…javascript sources
enable support for transpiled sources
Collaborator
|
@igbopie there was a pretty significant refactor recently. Would you mind reimplementing with that as the base? |
added 2 commits
April 3, 2018 14:50
…n be pass with ember-cli-build
Collaborator
Author
|
I will take a look! Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I would like to add support to TS. My initial idea was to transpile TS to JS and pass that JS to BABEL using Babel-instrumenter. Then I realize that ember already knows how to build the code, why do we need to specify to coverage how to build the code? So I changed the addon hook to
postBuild, that way I get the compiled src and the srcMaps. I read the sourceMaps and I use that to display the code.This is a first approach. What do you think?
Thanks!