[WIP] Refactor to use babel-plugin-istanbul#141
Conversation
This has some negative effects still: * Does not re-write the paths to match "real" on disk paths * Does not instrument dummy app files (I think) Even with these negative side-effects, it has massive upside: * Massively less overall code to maintain * Does not require us to parse babel config (and therefore avoids issues around parallelism in broccoli-babel-transpiler) * Significantly faster when used (e.g. no longer has to double parse and process files)
0f94156 to
8ed98e2
Compare
8ed98e2 to
1f2c10f
Compare
|
Will this get merged in the near term? @rwjblue or are the issues mentioned above blockers? |
| ); | ||
|
|
||
| reporter.addAll(config.reporters); | ||
| reporter.write(map); |
There was a problem hiding this comment.
Will this use the above config.coverageFolder?
|
Great to see this PR. This is kind of a blocker for us. Waiting for this to be merged :-) |
|
FWIW, there are still some issues with this approach to be ironed out (mentioned some of them in the TODO's in the description), but I don't have the bandwidth to continue pushing it forward. Definitely would love someone to take a stab at test driving things and PR'ing fixes back to this branch... |
|
Hi! I have a question. Ember has the 'knowledge' how to build our code, isn't it possible to leverage that 'knowledge' and just use source maps to get the real source code?. Thanks! |
…on-updates [WIP] Refactor to use babel-plugin-istanbul cont.
|
Thanks to the great work by @adamjmcgrath this is ready and working! There may still be some things we need to add support for, but I am going to merge this in. I will release a beta version, and it would be great if people could help test it out 😃 |
This has some negative effects still:
Even with these negative side-effects, it has massive upside:
around parallelism in broccoli-babel-transpiler)
process files)
.istanbul.ymlfile (very little documentation about this, but we are going through the default istanbul code path that loads config)TODO: