allow for a wider range of embroider dependencies#379
Closed
mansona wants to merge 2 commits intoember-cli-code-coverage:masterfrom
Closed
allow for a wider range of embroider dependencies#379mansona wants to merge 2 commits intoember-cli-code-coverage:masterfrom
mansona wants to merge 2 commits intoember-cli-code-coverage:masterfrom
Conversation
Collaborator
|
In general, this seems good to me. I'm not sure why CI didn't run though 🤔 |
Collaborator
Author
|
This is fixed in #382 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my second attempt at fixing my tests downstream. #378 wasn't enough of a change
This PR should be ok to merge and release as a minor and shouldn't interfere with any embroider dependencies dowstream.
Note: I needed to re-role the yarn.lock file in this PR because there are some babel changes that were causing some issues and the primary advice seems to be to re-roll your lock file 🤷 babel/babel#12949
I also had to update snapshots since there was some slight change. I'm assuming this is just as a result of the yarn.lock bump 👍