fix: use ValueError and fix f-string interpolation in yaml_loader#6263
Closed
korbonits wants to merge 1 commit intofeast-dev:masterfrom
Closed
fix: use ValueError and fix f-string interpolation in yaml_loader#6263korbonits wants to merge 1 commit intofeast-dev:masterfrom
korbonits wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Replace bare Exception with ValueError in yaml_loader and
_get_yaml_contents for more specific error handling. Also fix
a broken f-string interpolation (${yaml_strings} → {yaml_strings})
in the error message.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Korbonits <alex@korbonits.com>
Author
|
Sorry this is dead code, going to close this PR. Maybe I will raise another to delete it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes two issues in
sdk/python/feast/loaders/yaml.py:${yaml_strings}in the error message on line 25 does not interpolate in Python — the$prefix is invalid and the variable value was never included in the error string. Fixed to{yaml_strings}.yaml_loaderand_get_yaml_contentsraised bareExceptioninstead ofValueError, making it harder for callers to catch specific errors.Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy