Skip to content

fix: use ValueError and fix f-string interpolation in yaml_loader #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
korbonits wants to merge 1 commit into from
+3 −3
Closed

fix: use ValueError and fix f-string interpolation in yaml_loader #6263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/python/feast/loaders/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ def yaml_loader(yml, load_single=False):
# Return a single resource dict
if load_single:
if len(yaml_strings) > 1:
raise Exception(
f"More than one YAML file is being loaded when only a single file is supported: ${yaml_strings}"
raise ValueError(
f"More than one YAML file is being loaded when only a single file is supported: {yaml_strings}"
)
return _yaml_to_dict(yaml_strings[0])

Expand Down Expand Up @@ -56,7 +56,7 @@ def _get_yaml_contents(yml: str) -> str:
elif isinstance(yml, str):
yml_content = yml
else:
raise Exception(
raise ValueError(
f"Invalid YAML provided. Please provide either a file path or YAML string.\n"
f"Provided YAML: {yml}"
)
Expand Down